Social | Fix connected accounts not marked as such on confirmation screen

[manzoorwanijk]

Problem: get_all_connections_for_blog_id() and get_services() here return connections in different formats, while the former internally using populate_keyring_tokens_for_connections() which correctly sets the external_ID but the later does not.

Manifestation: Already connected accounts (e.g. Facebook) are not marked as such on the confirmation screen.

Reason: The connection test results API call uses that get_services which returns the user external ID, not the facebook page ID and then it overrides the data in the store.

So, initial state will have the correct external_id but not the connection test results.

Solution: Always use get_all_connections_for_blog_id to get the connections and then filter based on the site context or user context.

Proposed changes:

• Use get_all_connections_for_blog_id to get the connections and then filter based on the site context or user context.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Connect a Facebook page
• Now click on Connect for Facebook again
• Confirm that the connection is now marked as already connected
• Verify that admin sees their own connections
• Verify that an author sees their own and shared connections

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/social-connected-accounts-not-marked-as-such branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack fix/social-connected-accounts-not-marked-as-such
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
   • A. Team Review: add the "[Status] Needs Team Review" label
     • For most changes, including minor cross-team impacts.
     • Example: Updating a team-specific component or a small change to a shared library.
   • B. Crew Review: add the "[Status] Needs Review" label
     • For significant changes to core functionality.
     • Example: Major updates to a shared library or complex features.
   • C. Both: Start with Team, then request Crew
     • For complex changes or when you need extra confidence.
     • Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

[gmjuhasz]

Works as expected