Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate views: Enhance notices #40996

Merged
merged 7 commits into from
Jan 14, 2025

Conversation

mmtr
Copy link
Member

@mmtr mmtr commented Jan 13, 2025

Fixes Automattic/wp-calypso#98256
Fixes Automattic/wp-calypso#98258

Proposed changes:

Applies several enhancements to the notices displayed to users participating in the "Remove duplicate views" experiment:

  • Removes the %s variable from the notices title since it can lead to translations issues (p1736515477431359/1736434378.836679-slack-C02AED43D) and hardcode the title instead.
  • Updates the notices description to use the recommended possessive for WordPress: WordPress' (instead of WordPress's).
  • Prevents the notices from appearing on new sites created after the experiment start date.
  • Prevents the notices from appearing if they have been dismissed on a different site.
Screenshot 2025-01-13 at 13 50 38

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Assign yourself to the treatment variant of the 22129-explat-experiment experiment
  • Apply these changes to your sandbox
  • Go to wordpress.com/start and create a new Simple site
  • Sandbox this new site
  • On the new site, visit any of the enforced WP Admin views:
    • edit.php
    • edit.php?post_type=page
    • edit.php?post_type=jetpack-portfolio
    • edit.php?post_type=jetpack-testimonial
    • edit-comments.php
    • edit-tags.php?taxonomy=category
    • edit-tags.php?taxonomy=post_tag
  • Make sure the notices don't show up
  • Sandbox now an old site created before 2025-01-13
  • On the old site, visit any of the enforced WP Admin views
  • Make sure the notices show up
  • Switch your language to English
  • Make sure you see the new description with the correct possessive form of WordPress (WordPress').
  • Switch your language to other than English
  • Make sure you see the previous but translated description with the wrong possessive form of WordPress (WordPress's).
  • Dismiss the notice
  • Sandbox now another old site
  • On the different old site, visit the enforced WP Admin view of the notice you dismissed before
  • Make sure the notice does not show up
  • On the different old site, visit another enforced WP Admin view where you have not dismissed the notice
  • Make sure the notice shows up
  • Apply these changes now to an Atomic site created before 2025-01-13
  • On the Atomic site, visit the enforced WP Admin view of the notice you dismissed before
  • Make sure the notice does not show up
  • On the Atomic site, visit another enforced WP Admin view where you have not dismissed the notice
  • Make sure the notice shows up
  • Dismiss the notice
  • Make sure same notice does not show up on Simple sites

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Copy link
Contributor

github-actions bot commented Jan 13, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/remove-duplicate-views-notices-improvements branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/remove-duplicate-views-notices-improvements
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

mmtr added 3 commits January 13, 2025 18:18
…ate-views-notices-improvements

# Conflicts:
#	projects/packages/jetpack-mu-wpcom/src/features/wpcom-admin-interface/removed-calypso-screen-notice.tsx
Copy link
Contributor

@BogdanUngureanu BogdanUngureanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mmtr mmtr merged commit fb02c12 into trunk Jan 14, 2025
57 checks passed
@mmtr mmtr deleted the update/remove-duplicate-views-notices-improvements branch January 14, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants