-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate views: Enhance notices #40996
Remove duplicate views: Enhance notices #40996
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
projects/packages/jetpack-mu-wpcom/src/features/wpcom-admin-interface/wpcom-admin-interface.php
Outdated
Show resolved
Hide resolved
…ate-views-notices-improvements # Conflicts: # projects/packages/jetpack-mu-wpcom/src/features/wpcom-admin-interface/removed-calypso-screen-notice.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes Automattic/wp-calypso#98256
Fixes Automattic/wp-calypso#98258
Proposed changes:
Applies several enhancements to the notices displayed to users participating in the "Remove duplicate views" experiment:
%s
variable from the notices title since it can lead to translations issues (p1736515477431359/1736434378.836679-slack-C02AED43D) and hardcode the title instead.WordPress'
(instead ofWordPress's
).Other information:
Jetpack product discussion
N/A
Does this pull request change what data or activity we track or use?
No
Testing instructions:
treatment
variant of the 22129-explat-experiment experimentWordPress'
).WordPress's
).