Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms: rename "URL" field to "Website" and update icon #40994

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

simison
Copy link
Member

@simison simison commented Jan 13, 2025

Follow up to #40921

Proposed changes:

  • For consistency, call the field "Website" just like the label in the block. URL is commonly understood term, but "Website" feels more user friendly/human language.
  • Update icon to globe from WP Icons library. Regocniceable symbol felt better than tiny text "URL" that can be hard to read since it's so small.

Before

Screenshot 2025-01-13 at 13 44 13

After

Screenshot 2025-01-13 at 13 52 04

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Insert form, see URL field before/after

@simison simison added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Package] Forms [Feature] Forms Blocks Blocks designed to streamline user input and engagement, such as contact, newsletter sign-ups, etc. labels Jan 13, 2025
@simison simison requested review from ntsekouras and a team January 13, 2025 11:54
@simison simison marked this pull request as ready for review January 13, 2025 11:54
Copy link
Contributor

github-actions bot commented Jan 13, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jan 13, 2025
Copy link
Contributor

github-actions bot commented Jan 13, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/forms-url-field-rename branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/forms-url-field-rename
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@simison simison added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] In Progress labels Jan 13, 2025
@simison simison force-pushed the update/forms-url-field-rename branch from 255ea38 to 5b95486 Compare January 13, 2025 15:42
ntsekouras
ntsekouras previously approved these changes Jan 14, 2025
Copy link
Member

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Regarding the icon I don't have any feedback design wise, but it's the one associated with a link for sure and seems okay to me.

@simison
Copy link
Member Author

simison commented Jan 14, 2025

Changing the icon to "globe" for now as it makes actually more sense and is more common.

image

Checking with designers in Slack (internal ref p1736849966095219-slack-C0D96691V) — Update: globe it is!

@simison simison added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jan 14, 2025
@simison simison merged commit d52d80b into trunk Jan 14, 2025
62 checks passed
@simison simison deleted the update/forms-url-field-rename branch January 14, 2025 10:59
@simison simison changed the title Forms: rename "URL" field to "Website" Forms: rename "URL" field to "Website" and update icon Jan 14, 2025
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Feature] Forms Blocks Blocks designed to streamline user input and engagement, such as contact, newsletter sign-ups, etc. [Package] Forms [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants