Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PieChart: iterate over component. Introduce size, thickness and padding property #40993

Merged
merged 7 commits into from
Jan 13, 2025

Conversation

retrofox
Copy link
Contributor

@retrofox retrofox commented Jan 13, 2025

  • Add the padding component property to be able to remove the space.

It's required for us. Otherwise, removing the unneeded padding from the chart will get tricky.
In the following screenshot, the padding around the chart (SVG) affects the Widget layout.

Screenshot 2025-01-13 at 11 46 37 AM
  • consistency between PieChart and PieSemiCircleChart
    • Remove width and height properties in favor of size
    • BREAKING CHANGE: Adding the thickness property. Removes innerRadius property

Fixes #

Proposed changes:

  • iterate over component PieChart: introduce size, thickness and padding property

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Use storybook to test the component through its stories

  • Confirm that when there is no padding, the SVG element takes the whole size (width):
Screenshot 2025-01-13 at 11 28 04 AM
  • Play with the story controls. Confirm it is possible to change size, thickness, and padding properly.
Screen.Recording.2025-01-13.at.11.39.04.AM.mov

Copy link
Contributor

github-actions bot commented Jan 13, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 13, 2025
@retrofox retrofox added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 13, 2025
@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 13, 2025
withTooltips = false,
innerRadius = 0,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope it isn't too late to remove this property 😬

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good from the Jetpack side at least 😄

@retrofox retrofox removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 13, 2025
Copy link
Contributor

@kangzj kangzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements! LGTM 👍

@retrofox retrofox merged commit d34f9d4 into trunk Jan 13, 2025
61 checks passed
@retrofox retrofox deleted the update/iterate-over-pie-chart-component branch January 13, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JS Package] Charts RNA [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants