Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate views: Fix background image for removed Calypso screen notice #40983

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

agrullon95
Copy link
Contributor

@agrullon95 agrullon95 commented Jan 13, 2025

Related to: Automattic/wp-calypso#98150

Proposed changes:

  • Updated the path for retrieving the Calypso screen notice background image from the CDN

The image should load from https://s0.wp.com/i/welcome-notices/removed-calypso-screen-bg-pattern.png

Before:

CleanShot 2025-01-13 at 13 36 03@2x

After:

CleanShot 2025-01-13 at 13 35 33@2x

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Visit the experiment page: 22129-explat-experiment
  • Assign yourself to the treatment variant
  • Go to wordpress.com and select a site with the default admin interface
  • Make sure the "Pages" menu links to WP Admin
  • Make sure you see an educational notice the first time you visit the WP Admin view
  • Verify the background image is loading correctly.

Copy link
Contributor

github-actions bot commented Jan 13, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added [Package] Jetpack mu wpcom WordPress.com Features [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 13, 2025
Copy link
Contributor

github-actions bot commented Jan 13, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/welcome-notice-background-pattern-image branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/welcome-notice-background-pattern-image
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@mmtr mmtr added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Team Review and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 13, 2025
mmtr
mmtr previously approved these changes Jan 13, 2025
Copy link
Member

@mmtr mmtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly!

@agrullon95 agrullon95 merged commit 84f924b into trunk Jan 14, 2025
58 checks passed
@agrullon95 agrullon95 deleted the update/welcome-notice-background-pattern-image branch January 14, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[mu wpcom Feature] Wpcom Admin Interface [Package] Jetpack mu wpcom WordPress.com Features [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants