Social: Base PR: Unified connections management #40679
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manzoorwanijk
force-pushed
the
social/unified-connections-management
branch
from
2d2dbd8 to
56c0fbc
Compare
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
manzoorwanijk
added
the
[Type] Enhancement
github-actions
bot
added
[Feature] Publicize
manzoorwanijk
force-pushed
the
social/unified-connections-management
branch
2 times, most recently
from
a749a20 to
9af33a7
Compare
* Create connections class for caching * Update script data to use connections from the REST endpoint * changelog * Restore deprecated connection fields for time being * Disable caching for now * Fix display_name for Mastodon * Remove the unused caching logic
manzoorwanijk
force-pushed
the
social/unified-connections-management
branch
from
9af33a7 to
4af0cc4
Compare
* Social: Use connections REST endpoint for initial state (#40677) * Create connections class for caching * Update script data to use connections from the REST endpoint * changelog * Restore deprecated connection fields for time being * Disable caching for now * Fix display_name for Mastodon * Remove the unused caching logic * Update connect-form.tsx * Create connections class for caching * Update types for connection object * Update connection actions to reflect new types * Mark 'id' as deprecated * Add changelog * Deprecated fields should be optional * Fix TS error * Update unit tests * Replace/remove deprecated props usage * Remove unused code * Fix connection selectors * Fix unit tests * Reduce the number of changes * Fix type * Oops! It should be negation * Restore class-connections.php
* Allow requests as blog in base controller * Add filters for connections controller * Add changelog * Update baseline.php * Rename the 'include' param to 'scope' for clarity * Return shared connections by default * Remove scope parameter in favour of request context * Only pass test_connections to WPCOM * Update baseline.php
* Update connections class to implement caching * Add get_all_for_user method * Pass cached connections to initial state * Invalidate cache on XMLRPC request * Add changelog * Remove eager loading of connections following cache invalidation * Improve clear caching logic to handle race condition
* Pass the connected users WPCOM data to the UI * Augment wpcom for user object * Create canUserManageConnection selector * Replace can_disconnect with the new selector * Fix unit tests * Add changelog * Fix user data for WPCOM sites * Fix unit tests * Add changelog
* Add "must_reauth" to status in REST schema * Restore the UI changes to consider must_reauth status * Add changelog * Don't disable connections with must_reauth status must_reauth means that the connection will break soon, but it still works. We'll display an appropriate notice. --------- Co-authored-by: Paul Bunkham <[email protected]>
…0982) * Create Proxy_Requests class for re-usability * Move is_wpcom utility to Publicize_Utils class * Move connections specific logic from REST controller to connections class * Add changelog * Update baseline.php * Move publicize permissions check to its own method
…reen (#40997) * Social | Fix connected accounts not marked as such on confirmation screen * Add a comment
…_id` (#41025) * Social | Update connections schema to change user_id to wpcom_user_id * Fix wpcom_user_id for post connections field * Add changelog
* WIP * Pass the connection ID in the URL * Pass connection_id for delete proxy request * Allow overriding $request_options * Clean up debugging * Add changelog * Add changelog for js changes * Fix static analysis issues * Remove unused code * Update baseline.php --------- Co-authored-by: Paul Bunkham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: