Protect: Fix in-progress fixer indicator

[dkmyta]

Description

Ensure the in-progress spinner renders when a threat fixer has that status.

Proposed changes:

• Fixes the existing redux state for threatsAreFixing
• Disable the Ignore/Fix threat buttons when a threat fixer is in-progress

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

• https://github.com/Automattic/jetpack-scan-team/issues/1226

Does this pull request change what data or activity we track or use?

• No

Testing instructions:

• Create a JN site
• Install the Jetpack Beta plugin and enable Protect using this PR as the feature branch
• Upgrade your plan
• Install a known threat that is fixable and run the scan to detect it
• Queue the fixer for the threat and ensure that for the duration that the threat has an in-progress fixer status:
  • A loading Spinner component is render in the Auto-fix column
  • The Ignore/Fix threat buttons are disable

Screenshots

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Protect plugin:

• Next scheduled release: July 2, 2024.
• Scheduled code freeze: June 24, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[nateweller]

Suggestion: I would use "patch" for this since it is a bug fix, will need to re-run ./tools/fixup-project-versions.sh if you decide to change it.

[nateweller]

Nice touch disabling the threat's action buttons when a fixer is running 👍

[nateweller]

Nice fix! Works great.

We could enhance this in the future (in both Protect and Calypso) to include a check for in-progress fixers on load/in the initial state.

Our polling for fixer status is also pretty aggressive (1 second), we could probably ease it off for longer running fixers.