Sitemaps: ensure one item in a news sitemap to ensure validitiy (#40893)

Automattic · Jan 24, 2025 · 3bfae29 · 3bfae29
1 parent 4daa973
commit 3bfae29
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/projects/plugins/jetpack/changelog/fix-empty-news b/projects/plugins/jetpack/changelog/fix-empty-news
@@ -0,0 +1,4 @@
+Significance: patch
+Type: bugfix
+
+Sitemaps: ensures a valid news sitemap is present even if no posts are eligible.
diff --git a/projects/plugins/jetpack/modules/sitemaps/sitemap-builder.php b/projects/plugins/jetpack/modules/sitemaps/sitemap-builder.php
@@ -1087,12 +1087,15 @@ public function news_sitemap_xml() {
 			);
 
 			$posts = $this->librarian->query_most_recent_posts( JP_NEWS_SITEMAP_MAX_ITEMS );
+			if ( empty( $posts ) ) {
+				$buffer->append( array( 'url' => array( 'loc' => home_url( '/' ) ) ) );
+			} else {
+				foreach ( $posts as $post ) {
+					$current_item = $this->post_to_news_sitemap_item( $post );
 
-			foreach ( $posts as $post ) {
-				$current_item = $this->post_to_news_sitemap_item( $post );
-
-				if ( false === $buffer->append( $current_item['xml'] ) ) {
-					break;
+					if ( false === $buffer->append( $current_item['xml'] ) ) {
+						break;
+					}
 				}
 			}