-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a check for missing swiftlint_version:
key
#139
Conversation
So that if it's missing we exit gracefully instead of having `docker run` error complaining about invalid syntax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
👋 @AliSoftware , I am seeing that you are updating the PS: Apologies, but I wasn't aware about this |
The update of the The |
Yea, apoligies for missing that, I kind of got used to just check these boxes without really paying close attention to them, working on multiple client/library projects that have a tons of them... 🤷 I should be careful with the tooling projects however, especially ones that I haven't contributed just yet... 😊
Yea, I know, I got the same while working on #138 . 🫣
Noted! 👍 |
Add a check for missing
swiftlint_version:
key, so that if it's missing we exit gracefully instead of havingdocker run
error complaining about invalid syntax[Internal Ref]: This came up as part of p1736899091552619/1736896890.515319-slack-CC7L49W13
CHANGELOG.md
if necessary.