-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/missing wp user type #988
base: develop
Are you sure you want to change the base?
Commits on Aug 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 33ae3b0 - Browse repository at this point
Copy the full SHA 33ae3b0View commit details
Commits on Sep 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 92c6725 - Browse repository at this point
Copy the full SHA 92c6725View commit details -
fix: making the update operation dependent on $append flag.
This might be a problematic decision. But the way I justify this change is that if you are appending co-authors, there may already be a WP_User set as the author. So we don't really have to care whether one is passed or not. Because of this, we do not need to forcibly return a `false` flag since that is confusing to the caller, especially because we actually do save the guest authors which are given in the call! Instead, if the $append flag is false, we should expect that at least one user will be a WP_User. In that case, if none is passed in, then there is a mismatch of the intended authors. Because now, the `wp_posts.post_author` column will have an old `wp_users.ID` which remains set and most likely isn't the intent of the caller.
Configuration menu - View commit details
-
Copy full SHA for b6a0598 - Browse repository at this point
Copy the full SHA b6a0598View commit details -
fix: attempting DB update only when $new_author is not empty.
Also, returning the actual response from the DB, to make this call even more accurate in terms of what is actually happen at the DB layer.
Configuration menu - View commit details
-
Copy full SHA for 017dc74 - Browse repository at this point
Copy the full SHA 017dc74View commit details -
fix: need to ensure pure WP_User is processed correctly as post_author.
A pure WP_User (i.e. a WP_User that IS NOT linked to a Guest Author) needs to be handled specially.
Configuration menu - View commit details
-
Copy full SHA for a0635df - Browse repository at this point
Copy the full SHA a0635dfView commit details -
fix: a necessary refactor of the
get_coauthor_by
function.This refactor is absolutely necessary in order for all the previous fixes to work as expected. Without this fix, what happens is that when you use `get_coauthor_by` by searching with a Guest Author, if that Guest Author has a valid link to a WP_User, it is summarily ignored. Functions like `add_coauthors` expect at least one coauthor to be a valid WP_User so that the `wp_posts.post_author` column can be appropriately updated. The only case where this function is returning an expected value is when you search by the WP_User first. When it arrives at `$guest_author = $this->guest_authors->get_guest_author_by( $key, $value, $force );`, `$guest_author === false`. It is then forced to move to the switch statement to find a user via their WP_User data. With this refactor, `get_coauthor_by` will now check if the `linked_account` attribute is set. If so, it will attempt to find the corresponding user for the Guest Account. It still gives priority to returning a Guest Author. When a Guest Author is not found, it will search for a WP_User. If found, it will also search to see if a linked Guest Author account exists. If it does, it will return that Guest Author object instead, without losing the fact that this account also has a WP_User associated with it.
Configuration menu - View commit details
-
Copy full SHA for da28669 - Browse repository at this point
Copy the full SHA da28669View commit details -
fix: returning a plain WP_User if guest authors is not enabled.
I forgot to run tests on my previous commit. This satisfies the test Test_CoAuthors_Plus::test_get_coauthor_by_when_guest_authors_not_enabled which is expecting a WP_User when the plugin is not enabled.
Configuration menu - View commit details
-
Copy full SHA for b71ea29 - Browse repository at this point
Copy the full SHA b71ea29View commit details
Commits on Sep 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fbf2087 - Browse repository at this point
Copy the full SHA fbf2087View commit details -
Configuration menu - View commit details
-
Copy full SHA for 756d9fc - Browse repository at this point
Copy the full SHA 756d9fcView commit details
Commits on Sep 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0d55c46 - Browse repository at this point
Copy the full SHA 0d55c46View commit details -
Configuration menu - View commit details
-
Copy full SHA for e64921e - Browse repository at this point
Copy the full SHA e64921eView commit details -
fix: making the update operation dependent on $append flag.
This might be a problematic decision. But the way I justify this change is that if you are appending co-authors, there may already be a WP_User set as the author. So we don't really have to care whether one is passed or not. Because of this, we do not need to forcibly return a `false` flag since that is confusing to the caller, especially because we actually do save the guest authors which are given in the call! Instead, if the $append flag is false, we should expect that at least one user will be a WP_User. In that case, if none is passed in, then there is a mismatch of the intended authors. Because now, the `wp_posts.post_author` column will have an old `wp_users.ID` which remains set and most likely isn't the intent of the caller.
Configuration menu - View commit details
-
Copy full SHA for c0344db - Browse repository at this point
Copy the full SHA c0344dbView commit details -
fix: attempting DB update only when $new_author is not empty.
Also, returning the actual response from the DB, to make this call even more accurate in terms of what is actually happen at the DB layer.
Configuration menu - View commit details
-
Copy full SHA for 7ece2ab - Browse repository at this point
Copy the full SHA 7ece2abView commit details -
fix: need to ensure pure WP_User is processed correctly as post_author.
A pure WP_User (i.e. a WP_User that IS NOT linked to a Guest Author) needs to be handled specially.
Configuration menu - View commit details
-
Copy full SHA for 741c053 - Browse repository at this point
Copy the full SHA 741c053View commit details -
fix: a necessary refactor of the get_coauthor_by function.
This refactor is absolutely necessary in order for all the previous fixes to work as expected. Without this fix, what happens is that when you use `get_coauthor_by` by searching with a Guest Author, any link to a WP_User the Guest Author may have is summarily ignored. Functions like `add_coauthors` expect at least one coauthor to be a valid WP_User so that the `wp_posts.post_author` column can be appropriately updated. The only case where this function is currently returning an expected value is when you search by a WP_User account/field first. When it arrives at `$guest_author = $this->guest_authors->get_guest_author_by( $key, $value, $force );`, `$guest_author === false`. It is then forced to move to the switch statement to find a user via their WP_User data. With this refactor, `get_coauthor_by` will now check if the `linked_account` attribute is set. If so, it will then attempt to find the corresponding WP_User for the Guest Author. Crucially, it still gives priority to returning a Guest Author. When a Guest Author is not found, it will then attempt to search for a WP_User. If found, it will also search to see if a linked Guest Author account exists. If it does, it will return that Guest Author object instead, without losing the fact that this account also has a WP_User associated with it.
Configuration menu - View commit details
-
Copy full SHA for e9e76af - Browse repository at this point
Copy the full SHA e9e76afView commit details -
fix: renaming user_login's for new authors introduced for new tests.
These user_login's were causing other tests to fail because you cannot create another user with the same user_login.
Configuration menu - View commit details
-
Copy full SHA for e7c7792 - Browse repository at this point
Copy the full SHA e7c7792View commit details -
fix: removing use of assertObjectHasProperty
Older version of PHPUnit do not have this function available. Updating to workaround: `assertTrue( property_exists( $obj, 'prop' ) )`
Configuration menu - View commit details
-
Copy full SHA for b6b959b - Browse repository at this point
Copy the full SHA b6b959bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 41006b3 - Browse repository at this point
Copy the full SHA 41006b3View commit details
Commits on Oct 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1a2d06f - Browse repository at this point
Copy the full SHA 1a2d06fView commit details
Commits on Oct 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7e4bd8e - Browse repository at this point
Copy the full SHA 7e4bd8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for aacd37b - Browse repository at this point
Copy the full SHA aacd37bView commit details -
Configuration menu - View commit details
-
Copy full SHA for fc05f9d - Browse repository at this point
Copy the full SHA fc05f9dView commit details -
fix: removing use of newly introduced is_wp_user property.
Relying instead on wp_user property which has already been used before.
Configuration menu - View commit details
-
Copy full SHA for a0b808a - Browse repository at this point
Copy the full SHA a0b808aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e3a120a - Browse repository at this point
Copy the full SHA e3a120aView commit details
Commits on Oct 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6afab35 - Browse repository at this point
Copy the full SHA 6afab35View commit details
Commits on Jan 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 719c15c - Browse repository at this point
Copy the full SHA 719c15cView commit details
Commits on May 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3c27322 - Browse repository at this point
Copy the full SHA 3c27322View commit details
Commits on Jul 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 175d8fe - Browse repository at this point
Copy the full SHA 175d8feView commit details -
Configuration menu - View commit details
-
Copy full SHA for de55e39 - Browse repository at this point
Copy the full SHA de55e39View commit details
Commits on Jul 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8dd6d67 - Browse repository at this point
Copy the full SHA 8dd6d67View commit details -
Configuration menu - View commit details
-
Copy full SHA for db9a6d7 - Browse repository at this point
Copy the full SHA db9a6d7View commit details
Commits on Jul 4, 2024
-
add: new test solely for CoAuthorPlus::get_coauthor_by().
By fully testing CoAuthorPlus::get_coauthor_by(), we can remove some repetitive assertions that don't directly relate to what's being tested.
Configuration menu - View commit details
-
Copy full SHA for bbfc79a - Browse repository at this point
Copy the full SHA bbfc79aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 312d519 - Browse repository at this point
Copy the full SHA 312d519View commit details