Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

975-verification with isset before using properties #976

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

cobianzo
Copy link
Contributor

@cobianzo cobianzo commented Aug 2, 2023

Description

This is just one line of code to ensure that we are not trying to access to an non existing property in an instance of a coauthor.

Deploy Notes

No dependencies.

Steps to Test

Basic fix, just a regular use of the plugin to ensure it goes ok.

@GaryJones GaryJones added this to the 3.5.14 milestone Aug 2, 2023
@GaryJones GaryJones linked an issue Aug 19, 2023 that may be closed by this pull request
Copy link
Contributor

@GaryJones GaryJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see the fix causing any issues, though it would be good to understand why $coauthor isn't an object with the right properties.

@GaryJones GaryJones merged commit 68f0a8f into Automattic:master Aug 19, 2023
1 check passed
@GaryJones GaryJones mentioned this pull request Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix PHP Warnings on accessing $coauthor instance
2 participants