Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve I18n strings #963

Merged
merged 9 commits into from
Jul 29, 2023
Merged

Improve I18n strings #963

merged 9 commits into from
Jul 29, 2023

Conversation

GaryJones
Copy link
Contributor

Description

  • I18n: Add missing translators comments
  • I18n: Fix typos in strings
  • I18n: Remove error message from i18n
  • I18n: Mark-up pluralised strings correctly
  • I18n: Add text domain to PHPCS config
  • I18n: Add missing text domains
  • I18n: Remove post type labels placeholders
  • I18n: Use consistent translator comments
  • I18n: Refreshed .pot file

Deploy Notes

None specifically, though there should be new translations available for locales at https://translate.wordpress.org/projects/wp-plugins/co-authors-plus/ (as of now, en-gb has 100% completion of 129 strings in the Stable package).

Steps to Test

Error messages aimed at developers should not be translated.
This enables WPCS checks around i18n strings, such as missing or incorrect text domains.
While post type labels may be good as standalone labels for the UI, their use via placeholders in other strings may not work, since the value may change in the new context.
@GaryJones GaryJones added this to the 3.5.12 milestone Jul 29, 2023
@GaryJones GaryJones self-assigned this Jul 29, 2023
@GaryJones GaryJones merged commit c46ece8 into master Jul 29, 2023
10 checks passed
@GaryJones GaryJones deleted the fix/languages branch July 29, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant