Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests setup #949

Merged
merged 16 commits into from
Jul 24, 2023
Merged

Improve tests setup #949

merged 16 commits into from
Jul 24, 2023

Commits on Jul 23, 2023

  1. Tests: Use yoast/wp-test-utils

    This package combines the previously used PHPUnit_Polyfills with support for WordPress integration tests.
    GaryJones committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    8a738b7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5e8e845 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    208f721 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9474f85 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7044223 View commit details
    Browse the repository at this point in the history
  6. Tests: update fixture method names

    Needed to make tests compatible with multiple versions of PHPUnit.
    GaryJones committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    1028f9f View commit details
    Browse the repository at this point in the history
  7. Tests: Allow for assertArraySubset()

    This was deprecated in PHPUnit 8 and removed in PHPUnit 9, but the dms/phpunit-arraysubset-asserts means it can continue to be used for now.
    GaryJones committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    0dceaa2 View commit details
    Browse the repository at this point in the history
  8. Tests: avoid assertObjectHasProperty

    PHPUnit 9 deprecates `assertObjectHasAttribute()`. `assertObjectHasProperty()` is not available until PHPUnit 10.1, and only available with PHPUnit-Polyfills 2.0.0, which doesn't seem compatible with unit tests running under WP 5.7/5.8.
    GaryJones committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    fafa2bc View commit details
    Browse the repository at this point in the history
  9. Tests: Stop using arrayInternalType

    This was deprecated in PHPUnit 8 in favour of more specific method names.
    GaryJones committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    f64f05d View commit details
    Browse the repository at this point in the history
  10. Tests: Avoid assertNotContains() with strings

    Use `assertStringNotContainsString()` instead.
    GaryJones committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    57266e4 View commit details
    Browse the repository at this point in the history
  11. Tests: Refresh PHPUnit config

    - Removes constant that was making all tests run with multisite.
    - Converts deprecations to exceptions to be true.
    GaryJones committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    1ae729b View commit details
    Browse the repository at this point in the history
  12. Tests: Exclude groups for single/multisite

    By marking certain tests as being in a `@group`, and excluding them, then we can get a green result instead of yellow "tests skipped" results that we would do by marking tests as skipped of the single/multisite condition was not correct.
    GaryJones committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    f51ed90 View commit details
    Browse the repository at this point in the history
  13. Tests: Update Queried Object tests

    - Mark one test as requiring multisite.
    - Remove the other test, as it was causing an issue, and doesn't seem to be testing anything about CAP anyway.
    GaryJones committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    0f3def8 View commit details
    Browse the repository at this point in the history
  14. Tests: Apply fixes for PHP 8.1 and 8.2

    - Make dynamic properties explicit.
    - Skip a test that generates a deprecation notice in PHP 8.1 + WP < 6.3.
    GaryJones committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    43c4136 View commit details
    Browse the repository at this point in the history
  15. CI: Reduce matrix versions

    Highest and lowest versions of PHP 7, and PHP 8.
    Highest and lowest versions of WP, plus trunk.
    GaryJones committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    b38e1e5 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. CI: Install PHPUnit 7.5 for WP < 5.9

    See https://make.wordpress.org/core/2021/09/27/changes-to-the-wordpress-core-php-test-suite/#integration-tests-ci-changes - PHPUnit 9 removed a `PHPUnit\Util\Getopt` class, but the [fix](https://core.trac.wordpress.org/changeset/51570/) wasn't applied to WP until 5.9.
    
    Also - exclude WP 5.7 on PHP 8.2 since it is not supported.
    GaryJones committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    04137dd View commit details
    Browse the repository at this point in the history