-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve tests setup #949
Improve tests setup #949
Commits on Jul 23, 2023
-
Tests: Use yoast/wp-test-utils
This package combines the previously used PHPUnit_Polyfills with support for WordPress integration tests.
Configuration menu - View commit details
-
Copy full SHA for 8a738b7 - Browse repository at this point
Copy the full SHA 8a738b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e8e845 - Browse repository at this point
Copy the full SHA 5e8e845View commit details -
Configuration menu - View commit details
-
Copy full SHA for 208f721 - Browse repository at this point
Copy the full SHA 208f721View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9474f85 - Browse repository at this point
Copy the full SHA 9474f85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7044223 - Browse repository at this point
Copy the full SHA 7044223View commit details -
Tests: update fixture method names
Needed to make tests compatible with multiple versions of PHPUnit.
Configuration menu - View commit details
-
Copy full SHA for 1028f9f - Browse repository at this point
Copy the full SHA 1028f9fView commit details -
Tests: Allow for assertArraySubset()
This was deprecated in PHPUnit 8 and removed in PHPUnit 9, but the dms/phpunit-arraysubset-asserts means it can continue to be used for now.
Configuration menu - View commit details
-
Copy full SHA for 0dceaa2 - Browse repository at this point
Copy the full SHA 0dceaa2View commit details -
Tests: avoid assertObjectHasProperty
PHPUnit 9 deprecates `assertObjectHasAttribute()`. `assertObjectHasProperty()` is not available until PHPUnit 10.1, and only available with PHPUnit-Polyfills 2.0.0, which doesn't seem compatible with unit tests running under WP 5.7/5.8.
Configuration menu - View commit details
-
Copy full SHA for fafa2bc - Browse repository at this point
Copy the full SHA fafa2bcView commit details -
Tests: Stop using arrayInternalType
This was deprecated in PHPUnit 8 in favour of more specific method names.
Configuration menu - View commit details
-
Copy full SHA for f64f05d - Browse repository at this point
Copy the full SHA f64f05dView commit details -
Tests: Avoid assertNotContains() with strings
Use `assertStringNotContainsString()` instead.
Configuration menu - View commit details
-
Copy full SHA for 57266e4 - Browse repository at this point
Copy the full SHA 57266e4View commit details -
- Removes constant that was making all tests run with multisite. - Converts deprecations to exceptions to be true.
Configuration menu - View commit details
-
Copy full SHA for 1ae729b - Browse repository at this point
Copy the full SHA 1ae729bView commit details -
Tests: Exclude groups for single/multisite
By marking certain tests as being in a `@group`, and excluding them, then we can get a green result instead of yellow "tests skipped" results that we would do by marking tests as skipped of the single/multisite condition was not correct.
Configuration menu - View commit details
-
Copy full SHA for f51ed90 - Browse repository at this point
Copy the full SHA f51ed90View commit details -
Tests: Update Queried Object tests
- Mark one test as requiring multisite. - Remove the other test, as it was causing an issue, and doesn't seem to be testing anything about CAP anyway.
Configuration menu - View commit details
-
Copy full SHA for 0f3def8 - Browse repository at this point
Copy the full SHA 0f3def8View commit details -
Tests: Apply fixes for PHP 8.1 and 8.2
- Make dynamic properties explicit. - Skip a test that generates a deprecation notice in PHP 8.1 + WP < 6.3.
Configuration menu - View commit details
-
Copy full SHA for 43c4136 - Browse repository at this point
Copy the full SHA 43c4136View commit details -
Highest and lowest versions of PHP 7, and PHP 8. Highest and lowest versions of WP, plus trunk.
Configuration menu - View commit details
-
Copy full SHA for b38e1e5 - Browse repository at this point
Copy the full SHA b38e1e5View commit details
Commits on Jul 24, 2023
-
CI: Install PHPUnit 7.5 for WP < 5.9
See https://make.wordpress.org/core/2021/09/27/changes-to-the-wordpress-core-php-test-suite/#integration-tests-ci-changes - PHPUnit 9 removed a `PHPUnit\Util\Getopt` class, but the [fix](https://core.trac.wordpress.org/changeset/51570/) wasn't applied to WP until 5.9. Also - exclude WP 5.7 on PHP 8.2 since it is not supported.
Configuration menu - View commit details
-
Copy full SHA for 04137dd - Browse repository at this point
Copy the full SHA 04137ddView commit details