Guest Authors: Add labels property #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dynamically created class properties are deprecated in PHP 8.2, so this change explicitly defines the property in the class. It needs to be public, as it is used by the list table class when defining the search box label.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dynamically created class properties are deprecated in PHP 8.2, so this change explicitly defines the property in the class.
The
$labelsproperty is assigned to in the constructor of this Guest Authors class.The property needs to be public, as it is used by the list table class when defining the search box label.
Steps to Test
Note that running on PHP 8.2 generates a PHP deprecation message like:
After merging, this deprecation message will stop.