Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide deprecated social media links #830

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Hide deprecated social media links #830

merged 1 commit into from
Jul 24, 2023

Conversation

gamebits
Copy link
Contributor

@gamebits gamebits commented Nov 9, 2021

Checks the WordPress database version and hides the fields for Jabber, AIM, and Google Talk on newer sites. Closes #827.

@gamebits
Copy link
Contributor Author

gamebits commented Nov 9, 2021

Here's this branch running on a legacy WordPress install.
cap-old

And on a newer install:
cap-new

php/class-coauthors-guest-authors.php Outdated Show resolved Hide resolved
Copy link
Contributor

@rebeccahum rebeccahum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the failing tests please?

@rebeccahum
Copy link
Contributor

@lschuyler ^^

@lschuyler lschuyler self-assigned this Apr 22, 2022
@GaryJones GaryJones added this to the 3.5.12 milestone Jul 24, 2023
These were deprecated in/hidden since WP 3.6, so we’re fine to presume that simply don’t exist - we don’t need to support those fields in CAP, and there’s a filter if someone does want them added back in (along with any other contact methods).
@GaryJones
Copy link
Contributor

Rebased on to master (post 3.5.11 release, where CI tests were fixed up), and adjusted the code to simply remove the very old contact methods.

@GaryJones GaryJones dismissed rebeccahum’s stale review July 24, 2023 15:03

Code updated. Tests now pass.

Copy link
Contributor

@GaryJones GaryJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perform database check before loading legacy contact fields
4 participants