Increase minimum WordPress version to 5.9 #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecgeatches
changed the title
|
These tests are failing due to an older PHP version and mismatched dependency versions. After #1034 is merged, the tests here should pass. Please review that one first, thank you! |
|
After #1034 is merged, I'll want to rebase this and add some extra changes that would otherwise create merge conflicts. |
GaryJones
force-pushed
the
fix/minimum-wordpress-version
branch
from
fb7e41e
to
a6f2bb5
Compare
|
Rebased on to develop, and tweaked the integration test dependency ranges. |
Doesn't make sense to test WP versions would unsupported PHP versions (e.g. WP 5.9 with PHP 8.3).
|
✅ Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increase the minimum supported WordPress version to 5.9, which allows for a simpler tests setup, since all of the PHPUnit-Polyfills are bundled with WordPress core. This includes a handful of changes:
5.95.9at minimum5.9