Improve tests structure #1000
Merged
Improve tests structure #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation for test files to have namespaces.
As of PHPUnit 9.1.0, support for test file names which do not match the class name of the test class within, is deprecated. Support is expected to be removed completely in a future PHPUnit version. Effectively, this means that PHPUnit expects PSR4 to be followed for test classes.
Allows a future split out of Unit tests.
There are other `@covers` annotations that are either missing or a slightly different format (no leading slash, presence of parentheses) which is not covered here.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the state of the tests structure.
Tests: Use FQCN references
This is in preparation for test files to have namespaces.
Tests: Use PSR-4 filenames for test classes
As of PHPUnit 9.1.0, support for test file names which do not match the class name of the test class within, is deprecated. Support is expected to be removed completely in a future PHPUnit version. Effectively, this means that PHPUnit expects PSR4 to be followed for test classes.
Tests: Add namespaces and rename TestCase
Tests: Move into Integration directory
Allows a future split out of Unit tests.
Tests: Fix invalid covers annotations
There are other
@coversannotations that are either missing or a slightly different format (no leading slash, presence of parentheses) which is not covered here.Tests: Refresh PHPUnit config to add coverage
Coverage not added to CI yet as the
@coversannotations need reviewing and the tests also need reviewing.