EMSUSD-2154 honor the target-session option var #4120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Feb 12, 2025
pierrebai-adsk
commented
- Set the edit target in only one place when computing the proxy shape stage.
- If the proxy shape did not previously cache an edit target from a previous compute, then when choosing the edit target honor the option var that request the session layer to be targeted.
- This ensures the session layer is initially targeted, but if the target is manually changed afterward, we should respect that.
- Add a unit test to test the option var.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-2154/honor-target-session-optionvar
branch
from
35eadbf to
f00bcd0
Compare
- Set the edit target in only one place whencomputing the proxy shape stage. - If the proxy shape did not previously cache an edit target from a previous compute, then when choosing the edit target honor the option var that request the session layer to be targeted. - This ensures the session layer is initially targted, but if the target is manually changed afterward, we should respect that. - Add a unit test to test the option var.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-2154/honor-target-session-optionvar
branch
from
f00bcd0 to
9711909
Compare
AramAzhari-adsk
approved these changes
Feb 14, 2025
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
deleted the
bailp/EMSUSD-2154/honor-target-session-optionvar
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.