EMSUSD-126 fix finding strongest layer. #3498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Dec 5, 2023
pierrebai-adsk
commented
- Fix getStrongestLayer to find layers relative to their parent layer.
- Fix the reporting of unknown layers with a clearer message.
- Add a unit test for switching a variant in a sub-layer.
- Add a unit test for switching a variant in a sub-layer when the variant is in a reference.
- Fix getStrongestLayer to find layers relative to their parent layer. - Fix the reporting of unknown layers with a clearer message. - Add a unit test for switching a variant in a sub-layer. - Add a unit test for switching a variant in a sub-layer when the variant is in a reference.
samuelliu-adsk
approved these changes
Dec 7, 2023
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
added
ufe-usd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.