Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EMSUSD-835 - Provide access to the Export Selected options #3488

Merged
merged 4 commits into from
Dec 5, 2023
Merged

EMSUSD-835 - Provide access to the Export Selected options #3488

merged 4 commits into from
Dec 5, 2023

Conversation

samuelliu-adsk
Copy link
Collaborator

I think we still need to add them into default dictionary because ultimately we want to access this variable in export chasers

@samuelliu-adsk samuelliu-adsk added the import-export Related to Import and/or Export label Nov 29, 2023
JGamache-autodesk
JGamache-autodesk requested changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@JGamache-autodesk JGamache-autodesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, but incomplete. You need to also add the export selected option in UsdMayaExportTranslator::writer() in plugin\adsk\plugin\exportTranslator.cpp.

@samuelliu-adsk samuelliu-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Dec 1, 2023
@seando-adsk seando-adsk merged commit be465cd into dev Dec 5, 2023
@seando-adsk seando-adsk deleted the samuelliu-adsk/EMSUSD-835/export_selected branch December 5, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JGamache-autodesk JGamache-autodesk JGamache-autodesk approved these changes

Assignees

@ecp-maya-devops-adsk ecp-maya-devops-adsk

Labels
import-export Related to Import and/or Export ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samuelliu-adsk @JGamache-autodesk @seando-adsk @ecp-maya-devops-adsk