Skip to content

HYDRA-1586 : Add a unit test to check against regression with bifrost… #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

lanierd-adsk
Copy link
Collaborator

… graph updates

@lanierd-adsk lanierd-adsk requested a review from Copilot May 20, 2025 12:18
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new unit test to check against regression issues with bifrost graph updates. The test verifies the scene snapshots before and after a bifrost graph update is performed via a MEL command.

  • Adds a new test file for bifrost graph regression testing.
  • Validates scene changes by comparing pre- and post-update snapshots.
Files not reviewed (2)
  • test/lib/mayaUsd/render/mayaToHydra/CMakeLists.txt: Language not supported
  • test/testSamples/testBifrost/create_point_instancer_from_usd_file.json: Language not supported
Comments suppressed due to low confidence (2)

test/lib/mayaUsd/render/mayaToHydra/testBifrostGraphUpdate.py:39

  • [nitpick] Consider refactoring the long MEL command string into a dedicated variable or breaking it across multiple lines to enhance readability and simplify future maintenance.
mel.eval("vnnNode "|createPointInstancerFromUsdFile|createPointInstancerFromUsdFileShape" "/scatter_points" -setPortDefaultValues "amount" "150";")

test/lib/mayaUsd/render/mayaToHydra/testBifrostGraphUpdate.py:39

  • [nitpick] Add an inline comment to clarify the purpose of this MEL command, which updates the bifrost graph, for the benefit of future maintainers.
mel.eval("vnnNode "|createPointInstancerFromUsdFile|createPointInstancerFromUsdFileShape" "/scatter_points" -setPortDefaultValues "amount" "150";")

@lanierd-adsk lanierd-adsk requested a review from lilike-adsk May 20, 2025 12:21
@lanierd-adsk lanierd-adsk self-assigned this May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant