MSVC 14.3 fixes (adding <optional> includes) #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@boberfly Thanks for the contribution, would you mind to complete and return our MayaHydra CLA before we can process the PR? Thanks! |
|
@boberfly just a follow-up to see if you were able to figure out the CLA ? thanks |
|
@boberfly we really would like to take your contribution but we really need you to sign the CLA before we can do anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've just compiled with Visual Studio 17 2022 and found that a few
#include <optional>were required, so I've tweaked that up here.Cheers