-
Notifications
You must be signed in to change notification settings - Fork 2
build: setup ML workspace and VM cluster provisioning via bicep scripts #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
=======================================
Coverage 98.63% 98.63%
=======================================
Files 8 8
Lines 292 292
=======================================
Hits 288 288
Misses 4 4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Can you add a README.md that explains how to run this including what tools might be needed?
|
||
@description('The minimum number of nodes to use on the cluster. If not specified, defaults to 0') | ||
param minNodeCount int = 0 | ||
@description(' The maximum number of nodes to use on the cluster. If not specified, defaults to 4.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment says zero, but the default is 1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cluster does get provisioned with a minimum of 0 nodes. If I remember correctly, the cluster we had also had 0 as its minimum nodes.
Change Description
#21 Configuring bicep script for auto-provision of MLWorkspace and VMCluster
Solution Description
Code Quality
Project-Specific Pull Request Checklists
Bug Fix Checklist
New Feature Checklist
Documentation Change Checklist
Build/CI Change Checklist
Other Change Checklist