Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support to glob-like pattern #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added support to glob-like pattern #48

wants to merge 1 commit into from

Conversation

QuickGlare
Copy link

No description provided.

@sgdc3
Copy link
Member

sgdc3 commented Oct 16, 2019

@QuickGlare lol i missed this notification

@sgdc3 sgdc3 requested review from sgdc3 and ljacqu October 16, 2019 15:42
@sgdc3
Copy link
Member

sgdc3 commented Oct 16, 2019

why not using regex directly at this point?

@ljacqu
Copy link
Member

ljacqu commented Oct 16, 2019

Oh, I was on vacation when this came in and I wanted to comment on it: I'm thinking a combination of Pattern#escape and just having * function as wildcard would be sufficient, no? I think that would have low potential for errors or unexpected behavior and it's easy to explain that * = wildcard

@nickuc nickuc mentioned this pull request Mar 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgdc3 sgdc3 Awaiting requested review from sgdc3

@ljacqu ljacqu Awaiting requested review from ljacqu

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuickGlare @sgdc3 @ljacqu