Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle GitHub token revocation #1849

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Handle GitHub token revocation #1849

wants to merge 2 commits into from

Commits on Jan 17, 2020

  1. fix(projects): handle GitHub token revocation 

    When a GitHub request is made with a revoked token, the end user is
informed and asked to sign in again.
    @e18r
    e18r committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    cbbd9ed View commit details
    Browse the repository at this point in the history

  2. fix(projects): simplified useApolloClient hook 

    Previously, in order to use the Github API client, you had to:

1. Get the GitHub token from the appState
2. Call the `useApolloClient` hook and get the `initApolloClient` function
3. Call the `initApolloClient` function with the GitHub token as an
argument and get the client

But since `useApolloClient` is a hook, this commit simplifies it so
that the appState is accessed directly from within the hook, and the
actual API client is returned directly, so that the above steps get
simplified to:

1. Call the `useApolloClient` hook and get the client
    @e18r
    e18r committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    7284235 View commit details
    Browse the repository at this point in the history