Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Projects/App.js: memoize all the things #1703

Open
wants to merge 1 commit into
base: filterbar-context
Choose a base branch
from
Open

Projects/App.js: memoize all the things #1703

wants to merge 1 commit into from

Commits on Dec 3, 2019

  1. Projects/App.js: memoize all the things 

    We do not need or want to recalculate all of this stuff on every render
of App.js. In particular, this caused the entire Tabs bar and TabAction
(with associated MiniFilterBar) to be removed from the DOM and re-added
on every render.
    Chad Ostrowski committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    38968b3 View commit details
    Browse the repository at this point in the history