Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latest (experimental) versions of wrapper & api #1249

Merged
merged 3 commits into from
Sep 27, 2019
Merged

Use latest (experimental) versions of wrapper & api #1249

merged 3 commits into from
Sep 27, 2019

Commits on Sep 27, 2019

  1. Update aragonCLI 

    aragonCLI needs to be installed as a global package in order to work
correctly. This updates the README accordingly, and updates the `aragon`
commands to work with the new version:

• Use aragen address from latest CLI release in PlanningKit.sol

• Pass `--propagate-content false --skip-confirmation true`, which are
  now required for familiar v5 functionality

• Pipe 'yes' into 'aragon publish' commands. The new version of
  aragonCLI waits for user input saying this:

      → ? Couldn't reuse artifact due to mismatches, regenerate now? [y]es/[a]bort

  Long-term, we need to submit a patch to aragonCLI that allows
  automatically saying "yes" to this prompt, rather than waiting for
  user input. For now, we can pipe `yes` into it, which accomplishes
  what we want, but results in ugly logs.
    Quazia authored and Chad Ostrowski committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    7780dd0 View commit details
    Browse the repository at this point in the history

  2. Use latest (experimental) versions of wrapper & api 

    * use @aragon/api from https://github.com/AutarkLabs/aragon-api
* point aragonCLI at experimental fork of aragon client,
  AutarkLabs/aragon#27
* this client uses our own experimental version of
  @aragon/wrapper, https://github.com/AutarkLabs/aragon-wrapper
* Replace `api.cache` calls with `api.trigger`, which uses the
  still-experimental `trigger` interface under development at
  aragon/aragon.js#361
    Chad Ostrowski committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    f1d46ef View commit details
    Browse the repository at this point in the history

  3. Fix race condition during start:dev 

    There's no way to run `aragon devchain` that makes it return to the
terminal with the chain running in the background. Since it never
returns, there's no good & quick way to run these two commands
back-to-back. Instead, this gets around the problem most of the time by
giving the devchain ten seconds to start up before continuing.
    Chad Ostrowski committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    8bd084a View commit details
    Browse the repository at this point in the history