Skip to content

Commit

Permalink
fix(projects): enable radspec for external function
Browse files Browse the repository at this point in the history
- `fulfillBounty` radspec message now shows up in external tx panel
- remove extraneous logging from deploy script
- remove unneeded functions from Bounties interface
  • Loading branch information
topocount committed Jan 24, 2020
1 parent 2625d95 commit e16856c
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 22 deletions.
40 changes: 19 additions & 21 deletions apps/projects/contracts/Projects.sol
Original file line number Diff line number Diff line change
Expand Up @@ -14,27 +14,6 @@ import "@aragon/os/contracts/lib/math/SafeMath.sol";
* @dev Defines a minimal interface blueprint for the StandardBounties contract
*/
interface Bounties {
/**
* @notice Submit a fulfillment for issue #`_bountyId` with the following info: `_data`
*/
function fulfillBounty(
address _sender,
uint _bountyId,
address[] _fulfillers,
string _data
) external; //{}

/**
* @notice Update fulfillment for issue #`_bountyId` with the following info: `_data`
*/
function updateFulfillment(
address _sender,
uint _bountyId,
uint _fulfillmentId,
address[] _fulfillers,
string _data
) external; //{}

function issueBounty(
address sender,
address[] _issuers,
Expand Down Expand Up @@ -599,6 +578,25 @@ contract Projects is AragonApp, DepositableStorage {
}
}

/**
* @notice Submit a fulfillment for bounty #`_bountyId` with the following info: `_data`
* @dev This is a noop function implemented so the client can display the radspec
* for this external contract call
* @param _sender address of the user submitting the fulfillment
* @param _bountyId Standard Bounty Identifier
* @param _fulfillers array of users who contributed to the fulfillment of the bounty
* @param _data the provided proof of fulfillment
*/
function fulfillBounty(
address _sender,
uint _bountyId,
address[] _fulfillers,
string _data
) external
{
revert();
}

///////////////////////
// External utility functions
///////////////////////
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
const StandardBounties = artifacts.require("../contacts/StandardBounties.sol");

module.exports = function(deployer) {
console.log('test')
deployer.deploy(StandardBounties)
.then(instance => {
console.log(instance.address )
Expand Down

0 comments on commit e16856c

Please sign in to comment.