Skip to content

Commit

Permalink
Fix race condition during start:dev
Browse files Browse the repository at this point in the history
There's no way to run `aragon devchain` that makes it return to the
terminal with the chain running in the background. Since it never
returns, there's no good & quick way to run these two commands
back-to-back. Instead, this gets around the problem most of the time by
giving the devchain ten seconds to start up before continuing.
  • Loading branch information
Chad Ostrowski committed Sep 26, 2019
1 parent 28fee55 commit 4bcea2f
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions apps/shared/test-helpers/ganache-cli.sh
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ start_testrpc() {
aragon devchain --reset --port "$testrpc_port" &
elif [ "$DEV" = true ]; then
aragon devchain --reset --port "$testrpc_port" &
sleep 10 # wait for devchain to start TODO: modify cli to return rather than require interruption
npm run frontend &
elif [ "$NO_CLIENT" = true ]; then
aragon devchain --reset --port "$testrpc_port" &
Expand Down

0 comments on commit 4bcea2f

Please sign in to comment.