forked from DOI-USGS/ISIS3
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cicd action #63
Open
AustinSanders
wants to merge
32
commits into
dev
Choose a base branch
from
cicd_action
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Cicd action #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changed numpy pin to 1.22 * updated changelog * updated changelog
* std::unary/binary_function to std:::function * sprintf -> snprintf * vsprintf -> vsnprintf * fixed misc warnings * bypass jenkins error
* added quotes to Utilities.cmake * Added config for mac 13.4 * updated config to target macos13.5
* Update geos to 3.11.1 * Fixed failing test
…ance (DOI-USGS#4772) * findfeatures bug fixes and improvements * Fix matrix inversion error on empty matrix. (Fixes DOI-USGS#4639) * Identify images that fail FastGeom transform and exclude from matching. * Add TONOGEOM parameter to write failed file loads or FastGeom error file list if the transform cannot be determined * Improve FastGeom transform algorithm using new radial point mapping scheme * Add more debugging output to help diagnose problem images/procedures * findfeatures - add Grid algorithm to FastGeom * findfeatures mod to add Grid algorithm to FastGeom class * Improved Grid algorithm by computing proper starting iteration to statisfy fastgeompoints request * Added additional parameterization of Grid algorithm * Reorganized mapping process to consolidate Radial and Grid algorithms in FastGeom * findfeatures modifications after Astro code review findfeatures modifications: * Refactored FastGeom separating large sections of the compute() methods * Redesigned the the radial algorithm for easier user configuration * Added sanity checks avoid bad geometric correspondences * Added GLOBALS parameters for easy configuration of FastGeom algorithms at runtime * Fixed existing findfeatures test - error text The ThreeImageNetwork.FunctionalTestFindfeaturesErrorNoInput expects an error to be thrown with spectific text. The text in findfeatures.cpp was changed in this PR. It fixes the existing findfeatures test suite. * FastGeom.cpp updated to better accomodate testing * Add findfeatures Radial/Grid config files for test * Updated findfeatures test for Grid/Radial algos * Fixed cnetwinnow test that created misplaced files The cnetwinnow test needs tempDir().path() prepended to the “file_prefix” parameter to properly place the output files in the teardown directory. * Small adjustment to new findfeatures tests * Fixes/improvements to findfeature code - Improved reporting of parameterizations of findfeatures - Prevent creation of empty TONOTMATCH file when none are detected * Significant modifications/improvements to docs - Added two new examples demonstrating/documenting the use of FASTGEOM algorithm, parameterization using GLOBALS and how to produce a regional mosaic using findfeatures with batch scripts. - Reviewed, clarified and improved findfeatures program documentation * Updated the change log * Updates to findfeatures PR DOI-USGS#4772 - Modified findfeatures.xml documentation to address PR review feedback - Fixed use of projected images which wasn’t working due to improper instantiation of the cube projection object - Updated CHANGELOG.md to better categorize all changes in this PR * Removed scripts in example 4 of findfeatures docs - Per request via USGS review, removed the Bash shell scripts that produce the results of example 4 - Removed the $ISISROOT/appdata/templates/findfeatures/mosaics containing the scripts - Updated documentation in findfeatures.xml accordingly - Updated CHANGELOG.md accordingly
* fixes rclone duplication * updated changelog * Updated script * Addressed PR feedback
* cubeit attribute fix * Update changelog
* Updated cholmod calls to 64 bit * changed int triple indices to long * Fixed errorpropagation cholmod call * Updated changelog
* added findfeaturesSegment script * now parrallelized * updated logging code * added help string * added help string * added envs and fixed progress bar output * staging things * added python stuff, fixed segment issues, addressed coments * addressing comments * added more doc strings * made pybindings on by default * addressing comments * fixed some things, local testing * updated install steps * added basic tests * reverting ale pin * changed license * turn on pybindings in jenkins * renamed script * shadow rename?
* Prevent cube manager from setting the virtual band * Pass potential cube attributes through to the cube manager in campt * Added changelog entry * Fixed change log entry
* Squashing things added suffix and prefix capabilities in tgocassisstitch addresses DOI-USGS#5125, this allows the user to optionally use either the prefix or suffix option when stitching frames together, just use OUTPUTSUFFIX instead of OUTPUTPREFIX to use it. minor fixes typo more typos close to done, one error left need to figure out a replacement for ui.IsOptionSet as that is not actually a function. I need another way to test CLLI args. final fixes to implement ui changes fixed now employs a boolean flag to decide if the name parsed with out is a suffix or prefix, it defaults to a prefix. adding some tests to confirm output runs as expected. * adding to changelog * modified to allow prefix, suffix, both, or neither for better extensibility it also maintains original value names so older scripts and pipelines will retain functionality. adds another optional arg, cubename lets the user specify an optional cubename parameter which replaces the timestamp style naming for the output stitched cube. If the parameter is not given it defaults to the timestamp style naming convention for retaining existing functionality. * added details to changelog removed debugging code added changelog notes to xml for tgocassisstitch * typo in changelog * fixes from review added cubename argument logic typo in else statement * modifying tests removed faulty/old tests based on makefiles fixed single and multi frame tests for tgocassisstitch remaining tests fixed, one on EFS to check with jenkins. removed debug lines updated to remove nil randomly appearing in tests modified first stitch test to use fallback naming behaviour. * simplified some logic and removed repeat lines in different logic branches removing redundant lines from 8.0 release addresses prefix and filename convention topical issues * resolving changelog merge conflicts (I think) added details to changelog small typo in link * removed some dashes in tests and replaced a mistaken default filename * fixing the changleog resolves * modified to allow prefix, suffix, both, or neither for better extensibility it also maintains original value names so older scripts and pipelines will retain functionality. * added details to changelog changelog fixes removed typo * small test changes * cleaning up git artifacts left by squashing * changelog resolves
* Update parsing * Update parsing (#21) * Fix typo * PR ready * Fix comment typo
* Fixes dawn target translation for CERES images * Added Changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Validated?
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: