Adds a Pants slot #19999
Open
Adds a Pants slot #19999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alsoandanswer
requested review from
Arrow768,
JohnWildkins,
NonQueueingMatt and
DreamySkrell
as code owners
github-actions
bot
added
🗺️ Mapping - Away Ship/Away Site
|
!review |
DreamySkrell
approved these changes
Oct 30, 2024
Co-authored-by: Fluffy <[email protected]> Signed-off-by: Wowzewow (Wezzy) <[email protected]>
NonQueueingMatt
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin. Purely cosmetic for now. This is step zero.
Basically, clothing is starting to get real bloated with a lot of variants.
More pressingly, accessories as well, and we're probably going to get accessories of accessories.
After seeing what's going on with arm guards, leg guards, plate carriers and the like,
it's heading towards a really messy level of abstraction.
Hopefully this will nip it in the bud, so to speak.
I've also added the layering feature used in watches, so you can tuck in your uniform in your pants, or your coat in your pants if you're so inclined to.
This also means that in the near future, we'll finally have the ROLL PANTS feature that has escaped us for so long.
For reviewers :
This PR is majority legwork of simply adding the new pants slot in. Very similar to my previous Wrist slot PR.
The rest is just changing the existing pants/skirts over to a new loadout slot and changing paths.