[PE-6156] Deprecate fetch collections #12148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DejayJD
reviewed
May 20, 2025
Comment on lines
14
to
28
| export function* queryTrack(id: ID | null | undefined, forceRetrieve = false) { | ||
| if (!id) return null | ||
| const queryClient = yield* getContext('queryClient') | ||
| return queryClient.getQueryData(getTrackQueryKey(id)) | ||
| const sdk = yield* getSDK() | ||
| const currentUserId = yield* select(getUserId) | ||
| const dispatch = yield* getContext('dispatch') | ||
|
|
||
| const queryData = yield* call([queryClient, queryClient.fetchQuery], { | ||
| queryKey: getTrackQueryKey(id), | ||
| queryFn: async () => | ||
| getTrackQueryFn(id!, currentUserId, queryClient, sdk, dispatch), | ||
| staleTime: forceRetrieve ? 0 : undefined | ||
| }) | ||
|
|
||
| return queryData as TQTrack | undefined |
There was a problem hiding this comment.
Is this stuff already on main?
DejayJD
reviewed
May 20, 2025
Comment on lines
+77
to
+78
| export const resetCollection = (): ResetCollectionAction => ({ | ||
| type: RESET_COLLECTION |
DejayJD
reviewed
May 20, 2025
|
|
||
| const TRACKS_BATCH_LIMIT = 200 | ||
|
|
||
| export function* retrieveTracksForCollections( |
There was a problem hiding this comment.
since we're moving this around can we rename it queryTracksForCollection
DejayJD
reviewed
May 20, 2025
| trackIds: allSavedTrackIds.filter((id) => id !== null) | ||
| }) | ||
| const tracks = yield* call( | ||
| // @ts-ignore - Mobile for some reason fails to type-check this |
DejayJD
approved these changes
May 20, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecates fetch collections similar to tracks.