[PE-6156] Deprecate fetch collections #12148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DejayJD
reviewed
May 20, 2025
Comment on lines
14
to
28
| export function* queryTrack(id: ID | null | undefined, forceRetrieve = false) { | ||
| if (!id) return null | ||
| const queryClient = yield* getContext('queryClient') | ||
| return queryClient.getQueryData(getTrackQueryKey(id)) | ||
| const sdk = yield* getSDK() | ||
| const currentUserId = yield* select(getUserId) | ||
| const dispatch = yield* getContext('dispatch') | ||
|
|
||
| const queryData = yield* call([queryClient, queryClient.fetchQuery], { | ||
| queryKey: getTrackQueryKey(id), | ||
| queryFn: async () => | ||
| getTrackQueryFn(id!, currentUserId, queryClient, sdk, dispatch), | ||
| staleTime: forceRetrieve ? 0 : undefined | ||
| }) | ||
|
|
||
| return queryData as TQTrack | undefined |
There was a problem hiding this comment.
Is this stuff already on main?
DejayJD
reviewed
May 20, 2025
Comment on lines
+77
to
+78
| export const resetCollection = (): ResetCollectionAction => ({ | ||
| type: RESET_COLLECTION |
DejayJD
reviewed
May 20, 2025
|
|
||
| const TRACKS_BATCH_LIMIT = 200 | ||
|
|
||
| export function* retrieveTracksForCollections( |
There was a problem hiding this comment.
since we're moving this around can we rename it queryTracksForCollection
DejayJD
reviewed
May 20, 2025
| trackIds: allSavedTrackIds.filter((id) => id !== null) | ||
| }) | ||
| const tracks = yield* call( | ||
| // @ts-ignore - Mobile for some reason fails to type-check this |
DejayJD
approved these changes
May 20, 2025
|
audius-infra
pushed a commit
that referenced
this pull request
May 31, 2025
[388f90c] Rework remix lineup loading into redux (#12254) JD Francis [86979ce] Fix verified badge on settings page color (#12252) Ray Jacobson [c3ecd8a] [API-174] Add label account settings (#12240) Ray Jacobson [e69212a] E2E test: Better fix for collection edit timeouts on confirmation dialog (#12249) Marcus Pasell [dd84d89] Fix mobile fan remix contest winners selected notif (#12248) Reed [8e95a8b] [QA-2121] Fix track upload notification not linking to track page (#12247) JD Francis [15ba274] Small UI fixes for remix contests (#12246) Reed [d1a056f] Fix remix submission page loading (#12237) Dylan Jeffers [89c9e64] Fix listening history (#12236) JD Francis [eea0f83] Hotfix 400 messages crash (#12232) JD Francis [a9fa900] Fix crash in connectedWallets modal (#12211) Marcus Pasell [ad9599e] [PE-6046, PE-6283] Remove account collections selectors (#12208) Dylan Jeffers [11e9e57] [PE-6154] Migrate tip reactions to tanstack query (#12109) Dylan Jeffers [86f0b54] [PE-6272] Fix signed-out avatar account border (#12198) Dylan Jeffers [bcb3709] [PE-6222] Update overflow text colors (#12228) Dylan Jeffers [9dadb38] [PE-6253] Remix contest winner reward (#12220) Reed [5ee8340] [PE-6295] Fix popup positioning (#12230) Dylan Jeffers [d7df850] Skip album test (#12219) Dylan Jeffers [b1a0cdd] [PE-6297] Fix notification UI update (#12229) Dylan Jeffers [aba4efe] [PE-6294] Fix wallet UI breakpoint (#12227) Dylan Jeffers [d2a899e] [PE-6301] Fix player controls (#12226) Dylan Jeffers [7a4656b] [PE-6269] Fix write reactivity in updateTrackData (#12225) Dylan Jeffers [10d904e] Basic profile page vitest test (#12159) JD Francis [8fdfaf1] Fix search explore jitters + more (#12221) Isaac Solo [c5a1c1c] Dedupe ids in tan-query batch fetches (#12224) Dylan Jeffers [1f70f0b] [PE-6221] Remix contest winners selected notification (#12214) Reed [be4c315] [PE-6281] Make remix submission artwork fill container (#12218) Dylan Jeffers [ae76724] [PE-6289] Disable pick winners when no submissions (#12217) Dylan Jeffers [870220e] [PE-6280] Fix optimistic updates for remix winners (#12215) Dylan Jeffers [7bc2e70] Update BuySellFlow to have optimistic updates and fix M2 QA stuff (#12177) Farid Salau [4e54e52] Fix image profile size test (#12216) Isaac Solo [428c598] Fix min width and carousel buttons on explore (#12212) Isaac Solo [4b327e0] Fix some USDC balances not updating (#12210) Reed [c8f7466] [PE-6275, PE-6276, PE-6279, PE-6282] Pick Winners Milestone QA 1 (#12201) KJ [9461619] Web search/explore merge QA third pass (#12200) Isaac Solo [23e9bc6] Fix query track gc time (#12203) Dylan Jeffers [ed9afdd] [PE-6156] Deprecate fetch collections (#12148) Dylan Jeffers [e827fe2] [PE-6180] Web withdraw crypto UI updates (#12186) Reed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecates fetch collections similar to tracks.