Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved getRankedChords algorithm #43

Merged
merged 12 commits into from
Apr 20, 2024
Merged

Improved getRankedChords algorithm #43

merged 12 commits into from
Apr 20, 2024

Commits on Apr 12, 2024

  1. WIP minor major ninth not passing yet

    @maksutovic
    maksutovic committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    711e946 View commit details
    Browse the repository at this point in the history

  2. Added Minor Major Ninth chord type

    @maksutovic
    maksutovic committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    2d37b04 View commit details
    Browse the repository at this point in the history

  3. Added Major and Dominant Ninth Flat Five refactor of Flat Fifth to Fl… 

    …at Five in all cases

@aure
    @maksutovic
    maksutovic committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    1f869bf View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. WIP on new ranked chords algo 

    Co-authored-by: Aure <[email protected]>
    @maksutovic @aure
    maksutovic and aure committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    77341be View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. New algo working replacing old one

    @maksutovic
    maksutovic committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    f5f294c View commit details
    Browse the repository at this point in the history

  2. A few sus chords do not work due to algo being too eager to find thir… 

    …ds via letter
    @maksutovic
    maksutovic committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    7d0f3cb View commit details
    Browse the repository at this point in the history

  3. remade ranked chord algo with interval strategy

    @maksutovic
    maksutovic committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    628a9fd View commit details
    Browse the repository at this point in the history

  4. Fixed bug in Note.noteNumber causing infinite loop 

    Co-authored-by: Aure <[email protected]>
    @maksutovic @aure
    maksutovic and aure committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    7794566 View commit details
    Browse the repository at this point in the history

  5. Added isDouble as computed property to Accidental

    @maksutovic
    maksutovic committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    7762217 View commit details
    Browse the repository at this point in the history

  6. Improved getRankedChords algorithm 

    Co-authored-by: Aure <[email protected]>
    @maksutovic @aure
    maksutovic and aure committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    114ff8a View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into main

    @maksutovic
    maksutovic authored Apr 19, 2024
    Configuration menu
    Copy the full SHA
    b554d7b View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2024

  1. WIP cleaning up chord list refining examples and descriptions

    @maksutovic
    maksutovic committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    710b2c7 View commit details
    Browse the repository at this point in the history