WIP: Added new static Chord function to provide chord possibilities from [Notes] #19
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -90,7 +96,8 @@ class ChordIdentifier: ObservableObject { | |||
| } | |||
|
|
|||
| private func getPotentialChords() -> [Chord] { | |||
| return ChordTable.shared.getAllChordsForNoteSet(noteSet) | |||
| return Chord.getRankedChords(from: notes) | |||
| //return ChordTable.shared.getAllChordsForNoteSet(noteSet) | |||
There was a problem hiding this comment.
Comment Spacing Violation: Prefer at least one space after slashes for comments. (comment_spacing)
| func noteOff(pitch: Pitch) { | ||
| pitchSet.remove(pitch) | ||
| notes.removeAll(where: {$0.pitch == pitch}) | ||
| } | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| } | ||
|
|
||
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| @@ -90,7 +96,8 @@ class ChordIdentifier: ObservableObject { | |||
| } | |||
|
|
|||
| private func getPotentialChords() -> [Chord] { | |||
| return ChordTable.shared.getAllChordsForNoteSet(noteSet) | |||
| return Chord.getRankedChords(from: notes) | |||
| //return ChordTable.shared.getAllChordsForNoteSet(noteSet) | |||
There was a problem hiding this comment.
Comment Spacing Violation: Prefer at least one space after slashes for comments. (comment_spacing)
| func noteOff(pitch: Pitch) { | ||
| pitchSet.remove(pitch) | ||
| notes.removeAll(where: {$0.pitch == pitch}) | ||
| } | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| } | ||
|
|
||
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
|
Nice guys!! Excited to test this |
To help make #17 a reality, @aure and I are working on a new static function in
Chordthat can take an array ofNoteand provide ranked possible chords. This is still WIP (specifically around the demo portion of the code) but currently passing new test and will open up alot of possibilities.