Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make suspendedTriad into suspended4Triad and add suspended2Triad #18

Closed
wants to merge 1 commit into from
Closed

Make suspendedTriad into suspended4Triad and add suspended2Triad #18

wants to merge 1 commit into from

Conversation

Matt54
Copy link
Member

@Matt54 Matt54 commented Jan 22, 2024

Opening this up because I noticed this issue:
#17

I also ran into this problem and use this branch for Chordable with both sus2 and sus4 chords included.

This is still a WIP from the looks of it

aure
aure reviewed Jan 23, 2024
View reviewed changes
Copy link
Member

@aure aure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no tests of this addition, we're doing so now.

aure
aure requested changes Jan 23, 2024
View reviewed changes
Copy link
Member

@aure aure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs tests, but we'll probalby do so shortly.

@aure
Copy link
Member

aure commented Jan 23, 2024

Max and I have taken this further in the next pull request.

@aure aure closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aure aure aure requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Matt54 @aure