Convert the MS packet's contents to JSON, Client edition #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cerapter
commented
Feb 6, 2025
There was a problem hiding this comment.
This and it's cpp half are actually exactly the same on both Akashi and here.
It might be wise to relocate these two into a repo of their own, and then git submodule them into both, or something along those lines.
…rame SFX-es being sent over malformed
- Fix an issue where own offset was not sent over - Fix an issue where the pair's emote wasn't read from the JSON - Fix an issue where pair would be displayed no matter if they should be or not
|
The PR is ready to review. I tested all I could, but it obviously needs a much more intensive testing. |
Salanto
previously approved these changes
Feb 9, 2025
Salanto
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other half of the Akashi PR.
Unlike that one, this one is very heavily in progress.