Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reopen: Added missing path types #949

Merged
merged 8 commits into from
Jan 8, 2024

Conversation

videh25
Copy link
Contributor

@videh25 videh25 commented Dec 4, 2023

fix #341

Reopening the PR #892 since it was closed due to deletion of head repository.

Committed the same changes:

  1. Added missing RS paths and refactored the code.
  2. Modified assert condition in test3 of test_rrt_star_reeds_shepp.py.

Summarising the discussion from PR #892:

  1. "x" in the function names refers to the direction switches.
  2. Had to change the assert condition in test3 of test_rrt_star_reeds_shepp.py due to some strange behaviour. I have mentioned this in detail in this issue.

CheckList

  • Did you add an unittest for your new example or defect fix?
  • Did you add documents for your new example?
  • All CIs are green? (You can check it after submitting)

Copy link
Owner

@AtsushiSakai AtsushiSakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!!

@AtsushiSakai AtsushiSakai merged commit d7060f6 into AtsushiSakai:master Jan 8, 2024
8 checks passed
@videh25 videh25 deleted the missing_paths branch January 9, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing reeds_shepp curve type in reeds_shepp_path_planning.py
2 participants