Fixed Inappropriate Logical Expression

[fabihatasneem]

What does this implement/fix?

Inappropriate Logical Expression

Additional information

Details

While triaging your project, our bug fixing tool generated the following message(s)-

In file: arm_obstacle_navigation_2.py, the comparison of Collection length creates a logical short circuit. iCR suggested that the Collection length comparison should be done without creating a logical short circuit.

Notes

The condition len(route) >= 0 will always evaluate to true because the length can never be negative. If you intend to check whether route is not an empty collection, you can directly check for that:

if route:
    animate(grid, arm, route)

CLA Requirements

This section is only relevant if your project requires contributors to sign a Contributor License Agreement (CLA) for external contributions.

All contributed commits are already automatically signed off.

The meaning of a signoff depends on the project, but it typically certifies that committer has the rights to submit this work under the same license and agrees to a Developer Certificate of Origin (see https://developercertificate.org/ for more information).

Git Commit SignOff documentation

Sponsorship and Support:

This work is done by the security researchers from OpenRefactory and is supported by the Open Source Security Foundation (OpenSSF): Project Alpha-Omega. Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code - and get them fixed – to improve global software supply chain security.

The bug is found by running the Intelligent Code Repair (iCR) tool by OpenRefactory and then manually triaging the results.

CheckList

• Did you add an unittest for your new example or defect fix?
• Did you add documents for your new example?
• All CIs are green? (You can check it after submitting)

[AtsushiSakai]

LGTM. Thanks.