-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Update to match new specifications from dlc-specs PR 163 #187
Open
maxpolizzo
wants to merge
39
commits into
master
Choose a base branch
from
maxpolizzo/dlc-specs-163
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d9a0bf2
to
4b7cb03
Compare
ea7aa80
to
2ef6aaf
Compare
f7e383d
to
114a178
Compare
970db55
to
993da33
Compare
eb9fb65
to
30d1d54
Compare
30d1d54
to
7f3a5b9
Compare
2d4cbe6
to
3c29f36
Compare
…ckages/messaging/lib/messages/pre-167 --wip-- [skip ci]
…AttestationV0Pre167, DlcClose, DlcTransactions, OracleIdentifierV0, OrderAccept, OrderIrcInfo, OrderMetadata. Added OracleAttestationV0Pre163 and OracleIdentifierV0Pre163 classes with returned type in toJSON function. Renamed OracleIdentifierV0.ts to OracleIdentifier.ts. --wip-- [skip ci]
…erIrcInfo.ts and OrderMetadata.ts --wip-- [skip ci]
…cClose, OrderAccept, NodeAnnnouncementMessage, OracleAttestationV0Pre167 and OracleAnnouncementV0Pre167 --wip-- [skip ci]
…ry type conversions that had been used to circuvent the issue --wip-- [skip ci]
…aging/__tests__/messages/pre-163 --wip-- [skip ci]
…ec.ts --wip-- [skip ci]
…and temporaryConntractId keys everywhere --wip-- [skip ci]
…Pre163 and toPre163 functions --wip-- [skip ci]
…rs --wip-- [skip ci]
3c29f36
to
55e7831
Compare
…g deserialization --wip-- [skip ci]
de85a2a
to
567d0e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do:
pre163
andpre167
folders withPre163
orPre167
suffix (7aa86d7c3d2ba68a8d86d8ec69498707dd8bb676
)type
is returned bypre163
classestoJSON
function and make sure it is not in other classes. Classes where returnedtype
has been removed fromtoJSON
function must have apre163
version for backwards compatibility. (6916ce7b2c031af238a7a46197a59a3574b0ea3d
)DlcMessage.ts
to handle BigSize type deserialisation (bffd2c3be4d6e788a3e9741cbcf14f4869700f01
)DlcOffer
,DlcAccept
, andDlcSign
,DlcCancel
,DlcClose
,DlcIds
,DlcInfo
,DlcTransactions
,NodeAnnouncementMessage
,OrderAccept
,OrderIrcInfo
,OrderMetadata
,OrderOffer
messages should useUint16
to deserializetype
, and all sub-messages should useBigSize
iftype
is used for deserialisation (post163,type
is only used for deserialisation when there are several possible sub-types for a message class)type
should be inferred from the class itself (i.e. the class does not carrytype
), otherwisetype
should be added to the classlength
inOracleIdentifier.ts
,OrderIrcInfo.ts
andOrderMetadata.ts
(20c4bcab5787b2d7947fd9c7d0cc63f088f1c8b2
)ca939d55a1c1da8f5fd320d8fd523bc8c78d24b4
)reader
instantiation inpre163
, use new instantiation elsewhere (a7cca04b2b6dc49a59683fa41b75ce2513be145f
)DlcOffer
,DlcAccept
andDlcSign
andOrderOffer
already have TLV streams enabled. Add TLV streams toDlcClose
,OrderAccept
,NodeAnnnouncementMessage
,OracleAttestationV0Pre167
andOracleAnnouncementV0Pre167
(a142ab5fe728d1faac6ef76e260004f0611929b7
)OrderAccept
(458ea8390ce9c6f809d2a72592908743b340d676
)messages/ContractInfo.ts
, re-implementDisjointContractInfo.validate
(335895bc1e7d8b53ced2e90e7c24822e13ab123a
)ContractDescriptor.ts
anassert
clause was added to thedeserialize
function to check that the deserialised type is as expected: generalise this everywhere (34290675df4e81c685e5686c4dce68cf5e72a86b
)rocksdb
package (59f4fcb762c50d6eaadeef2efbb47094be71cefe
)core
package (e63be5d80dd77098f3b98167827ba3ff96fe9517
)bignumber.js
and@node-dlc/bitcoin
and remove unnecessary type conversions that had been used to circumvent the issue (1fbe6796cae9dd7f76503f116c6fc4c89d3ae1e1
)messaging
package (7cb1b78584f1ea15c37b049804b893ed5d87eb7c
)messaging
package (2edfc54de3d548b15d4de188aa973b93dcce86b2
)NodeAnnouncementMessage.spec.ts
test (4d32771fa631e2bcb9ff42b56a4268115eca7608
)rocksdb
packages and generalise usingofferCollateral
,acceptCollateral
andtemporaryConntractId
orders keys everywhere (19f48306a1df3dfbd4382172b685494d8ce9249a
)transport
package (86c783e52285282b6a31b9c0b0be44201ca52364
)toPre163
function to post-163 classes in messaging package and add corresponding tests (0fb761fd8a7b0d41f9c80183659c402e95cdbee4
)ScriptWitness
serialisation (fd856e6196b9dc36c7e7f832e1da49e45f08de53
)677d168ecd013c952a8a40f5e7267e79343d100e
)3b88c99c6e6f4832fa58fa7f5df496f162f7879c
)master
branch55e78311d2a71e9da8651f098743adb0dad88a91
)master
branch again after new commit tomaster
branchdeserializedBytes
during deserialization (567d0e0e65bc859f9e8cd41d88184ad3ac7bc7cd
)