Support v2 Linter API

[vzamanillo]

Fixes #147

[vzamanillo]

Ouch, whitequark/parser Warnings... related #117, #128

[vzamanillo]

Fixed

[Arcanemagus]

This could possibly be misconstrued to mean "Don't show me warning severity messages".

Maybe a better name would be suppressFailures? Is there any reason we don't just want to show all errors though? Generally that means something is wrong and the user isn't going to get any usable output otherwise.

[vzamanillo]

What about changing the message to "Supress non-critical HAML-Lint messages" or a better way, adding an excerpt message to the results and show notification for errors only?.

[vzamanillo]

Something like this

        const messages = [];

        if (output.exitCode !== 0) {
          if (output.stderr.toLowerCase().startsWith(warning)) {
            messages.push({
              severity: warning,
              excerpt: `HAML-Lint: ${output.stderr}`,
              location: {
                file: filePath,
                // first line of the file
                position: [[0, 0], [0, Infinity]],
              },
            });
          }
        } else {
          showErrorNotification('HAML-Lint: Unexpected error', output.stderr);
        }

[vzamanillo]

[Arcanemagus]

Adding it as a message looks great to me!

[vzamanillo]

Should we add the unexpected errors this way too? I mean, without notification.

[Arcanemagus]

The way I see it is:

• If the message prevents other results from being returned it should be an Atom error notification
• If other results can still be obtained from the linter then it probably should just be converted into a message on the entire first line

[vzamanillo]

👍

[vzamanillo]

hehehe

Expected 2 to be 1.

If we modify the specs to match this we must ensure that the ruby versions of the CI have an old compilant syntax (or do a unsafe conditional test case)

    if (messages.length === 1) {
      expect(messages[0].severity).toBe('warning');
      expect(messages[0].excerpt).toBe(excerpt);
      expect(messages[0].description).not.toBeDefined();
      expect(messages[0].url).toBe(url);
      expect(messages[0].location.file).toBe(cawsvpath);
      expect(messages[0].location.position).toEqual([[0, 0], [0, 23]]);
    } else if (messages.length === 2) {
      expect(messages[0].severity).toBe('warning');
      expect(messages[0].excerpt).toContain('haml-lint: warning');
      expect(messages[0].description).not.toBeDefined();
      expect(messages[0].url).not.toBeDefined();
      expect(messages[0].location.file).toBe(cawsvpath);
      expect(messages[0].location.position).toEqual([[0, 0], [0, Infinity]]);
    }

[Arcanemagus]

This looks good just looking at the code, is it ready to merge?

[vzamanillo]

This looks good just looking at the code, is it ready to merge?

Yep, it is ready!!