Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs around tokens and PWA #197

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Fix bugs around tokens and PWA #197

merged 2 commits into from
Apr 3, 2024

Conversation

Atmos4
Copy link
Owner

@Atmos4 Atmos4 commented Apr 3, 2024 •
edited
Loading

This PR fixes multiple issues:

  • allow user to have tokens on multiple devices at once (e.g. mobile and computer)
  • fix relative links in family_view, this was causing issues in the PWA version where relative links don't work well

@Atmos4 Atmos4 linked an issue Apr 3, 2024 that may be closed by this pull request
Stop revoking all tokens when logging in #194
Closed
@Atmos4 Atmos4 linked an issue Apr 3, 2024 that may be closed by this pull request
Actions in family view don't work properly #196
Closed
@Atmos4 Atmos4 changed the title Stop revoking all tokens on login Fix bugs around tokens and PWA Apr 3, 2024
@Atmos4 Atmos4 requested a review from Mathieu414 April 3, 2024 08:26
Mathieu414
Mathieu414 approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@Mathieu414 Mathieu414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Atmos4 Atmos4 merged commit f02062d into master Apr 3, 2024
1 check passed
@Atmos4 Atmos4 deleted the 194-stop-revoking-all-tokens-when-logging-in branch April 3, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mathieu414 Mathieu414 Mathieu414 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Actions in family view don't work properly Stop revoking all tokens when logging in
2 participants
@Atmos4 @Mathieu414