Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to pico v2 ✨ #191

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Migrate to pico v2 ✨ #191

merged 2 commits into from
Apr 2, 2024

Conversation

Atmos4
Copy link
Owner

@Atmos4 Atmos4 commented Apr 1, 2024

  • split pico and Bootstrap Grid css files
  • fix some migration issues
  • fix a small bug with event list not showing past event loader

There are still some issues to spot. This is just a first migration to clean things up.

Long term plan would be to also get rid of all CSS files in favor of something like UnoCSS (for maintainability's sake, and also for fun because why not). I will create a separate issue about this

- split pico and Bootstrap Grid
- fix some migration issues
- fix a small bug with event list not showing past event loader
@Atmos4 Atmos4 linked an issue Apr 1, 2024 that may be closed by this pull request
Mathieu414
Mathieu414 previously approved these changes Apr 2, 2024
Copy link
Collaborator

@Mathieu414 Mathieu414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

- improve some visual bugs related to Pico migration
- improve pfp visuals and a11y
- improve navbar a11y
Copy link
Collaborator

@Mathieu414 Mathieu414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@Atmos4 Atmos4 merged commit 7b3fdf0 into master Apr 2, 2024
1 check passed
@Atmos4 Atmos4 deleted the 190-migrate-to-pico-v2 branch April 2, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Pico v2 ✨
2 participants