skip calling notify method if there are no recipients #2835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Avetisyan <[email protected]>
Signed-off-by: Henry Avetisyan <[email protected]>
| // but we want to log it for debugging purposes | ||
|
|
||
| if (recipients.isEmpty()) { | ||
| LOGGER.error("No recipients specified in the notification. Subject={}", subject); |
There was a problem hiding this comment.
Should this be warn instead of error?
There was a problem hiding this comment.
we should treat it as an error since we're trying to send a notification but we don't have recipients.
MartinTrojans
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contribution Checklist:
Attach Screenshots (Optional)