Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JuliaFormatter #87

Merged
merged 5 commits into from
Dec 10, 2023
Merged

Add JuliaFormatter #87

merged 5 commits into from
Dec 10, 2023

Conversation

hyrodium
Copy link
Member

@hyrodium hyrodium commented Sep 23, 2023

This PR adds a formatter without formatting. I would like to add some GitHub Actions for this, but I'm not sure what's the best practice because the format_check.yml from the JuliaFormatter documentation uses Julia v1.3.0.

I will undraft this PR when I add some .yml file for GitHub Actions.

@hyrodium hyrodium force-pushed the feature/JuliaFormatter branch from 9422f93 to b76f5b4 Compare November 16, 2023 22:51
@hyrodium hyrodium force-pushed the feature/JuliaFormatter branch from b76f5b4 to 85e4f7f Compare December 2, 2023 07:31
Copy link

codecov bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b7cd460) 93.84% compared to head (82f98ae) 93.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #87   +/-   ##
=======================================
  Coverage   93.84%   93.84%           
=======================================
  Files          10       10           
  Lines         650      650           
=======================================
  Hits          610      610           
  Misses         40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/obj.jl Show resolved Hide resolved
src/obj.jl Outdated Show resolved Hide resolved
@hyrodium hyrodium marked this pull request as ready for review December 2, 2023 08:38
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@hyrodium hyrodium merged commit 9890ec2 into main Dec 10, 2023
12 of 13 checks passed
@hyrodium hyrodium deleted the feature/JuliaFormatter branch September 7, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants