Give the uniform thermophysical properties to all surface facets. #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an outer constructor of `ThermoParams`
Add `broadcast_thermo_params!`
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
==========================================
+ Coverage 93.96% 93.97% +0.01%
==========================================
Files 11 11
Lines 663 681 +18
==========================================
+ Hits 623 640 +17
- Misses 40 41 +1 ☔ View full report in Codecov by Sentry. |
Remove an unnecessary comment
Move `broadcast_thermo_params!` function into the `SingleTPM` constructor.
hyrodium
reviewed
Feb 2, 2025
|
|
||
| # Arguments | ||
| - `thermo_params` : Thermophysical parameters | ||
| - `n_face` : Number of faces of the shape model |
There was a problem hiding this comment.
Suggested change
| - `n_face` : Number of faces of the shape model | |
| - `n_face` : Number of faces on the shape model |
I think "on" would be more natural.
| @@ -89,7 +89,7 @@ | |||
| n_face_shape1 = length(shape1.faces) # Number of faces of Didymos | |||
| n_face_shape2 = length(shape2.faces) # Number of faces of Dimorphos | |||
|
|
|||
| ##= Thermal properties =## | |||
| ##= Thermal properties of Didymos & Dimorphos [c.f. Michel+2016; Naidu+2020] =## | |||
There was a problem hiding this comment.
Suggested change
| ##= Thermal properties of Didymos & Dimorphos [c.f. Michel+2016; Naidu+2020] =## | |
| ##= Thermal properties of Didymos & Dimorphos [cf. Michel+2016; Naidu+2020] =## |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If all facets have the same thermophysical properties, they are given as scalars rather than vectors.