Add api.md and physical_model.md #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
==========================================
+ Coverage 93.84% 93.90% +0.05%
==========================================
Files 10 10
Lines 650 656 +6
==========================================
+ Hits 610 616 +6
Misses 40 40 ☔ View full report in Codecov by Sentry. |
MasanoriKanamaru
approved these changes
Dec 3, 2023
docs/src/physical_model.md
Outdated
| | ``E`` | [J] | Energy | | ||
| | ``\Gamma`` | [?] | ? | | ||
| | ``\varepsilon`` | [?] | ? | | ||
| | ``\Phi`` | [?] | ? | |
There was a problem hiding this comment.
Suggested change
| | ``\Phi`` | [?] | ? | | |
| | ``\Phi`` | [W/m²] | Solar energy flux | |
In constants.jl, the same symbol is used as an orbital mean anomaly. This conflict will be resolved in the future.
There was a problem hiding this comment.
Should we use
Co-authored-by: M. Kanamaru <[email protected]>
Co-authored-by: M. Kanamaru <[email protected]>
Co-authored-by: M. Kanamaru <[email protected]>
Co-authored-by: M. Kanamaru <[email protected]>
Co-authored-by: M. Kanamaru <[email protected]>
Co-authored-by: M. Kanamaru <[email protected]>
Co-authored-by: M. Kanamaru <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: M. Kanamaru <[email protected]>
Co-authored-by: M. Kanamaru <[email protected]>
Co-authored-by: M. Kanamaru <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.