TPM result output: Time steps to save temperature #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
==========================================
+ Coverage 93.84% 93.90% +0.05%
==========================================
Files 10 10
Lines 650 656 +6
==========================================
+ Hits 610 616 +6
Misses 40 40 ☔ View full report in Codecov by Sentry. |
Change the arguments of the struct to store the TPM result from `time_begin` and `time_end ` to `times_to_save`.
MasanoriKanamaru
force-pushed
the
workflow/times-to-save
branch
from
c5d62c3 to
fcd6a20
Compare
Add `times` in `SingleTPMResult` to store the time steps of the entire simulation.
Use `result.times` instead of `ephem.time`
- Use `result.times` instead of `ephem.time` - Remove unnecessary arguments
- Use `result.times_to_save`
- Add `depth_nodes` in `SingleTPMResult` to store the depths of the calculation nodes for the 1-D heat conduction equation.
Just a cleanup
hyrodium
reviewed
Dec 2, 2023
Co-authored-by: Yuto Horikawa <[email protected]>
Co-authored-by: Yuto Horikawa <[email protected]>
Co-authored-by: Yuto Horikawa <[email protected]>
Use the `range` function for `et_range`
hyrodium
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timesteps to save the temperature are given as a vector.