use mulDivUp for fee rake

AstariaXYZ · Jan 24, 2024 · 469c413 · 469c413
1 parent 0791d30
commit 469c413
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.gas-snapshot b/.gas-snapshot
@@ -110,8 +110,8 @@ TestStarport:testCannotOriginateWhilePaused() (gas: 73479)
 TestStarport:testCannotSettleInvalidLoan() (gas: 74969)
 TestStarport:testCannotSettleUnlessValidCustodian() (gas: 71007)
 TestStarport:testCaveatEnforcerRevert() (gas: 102601)
-TestStarport:testDefaultFeeRake1() (gas: 383497)
-TestStarport:testDefaultFeeRake2() (gas: 445860)
+TestStarport:testDefaultFeeRake1() (gas: 383458)
+TestStarport:testDefaultFeeRake2() (gas: 445821)
 TestStarport:testDefaultFeeRakeExoticDebt() (gas: 394564)
 TestStarport:testEIP712Signing() (gas: 83109)
 TestStarport:testExcessiveFeeRake() (gas: 19992)
@@ -131,7 +131,7 @@ TestStarport:testInvalidateCaveatSalt() (gas: 33428)
 TestStarport:testNonDefaultCustodianCustodyCallFails() (gas: 264267)
 TestStarport:testNonDefaultCustodianCustodyCallSuccess() (gas: 290392)
 TestStarport:testNonPayableFunctions() (gas: 114479)
-TestStarport:testOverrideFeeRake() (gas: 379912)
+TestStarport:testOverrideFeeRake() (gas: 379873)
 TestStarport:testPause() (gas: 18127)
 TestStarport:testRefinancePostRepaymentFails() (gas: 127864)
 TestStarport:testStargateGetOwner() (gas: 8851)

diff --git a/src/Starport.sol b/src/Starport.sol
@@ -667,7 +667,7 @@ contract Starport is PausableNonReentrant {
 
                 uint256 bps = feeOverride.enabled ? feeOverride.bpsOverride : _defaultFeeRakeBps;
 
-                amount = debtItem.amount * bps / BPS_DENOMINATOR;
+                amount = debtItem.amount.mulDivUp(bps, BPS_DENOMINATOR);
 
                 if (amount > 0) {
                     feeItem.amount = amount;