Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADConversion effect #189

Draft
wants to merge 2 commits into
base: dev_master
Choose a base branch
from
Draft

ADConversion effect #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
829130f
Rename ADConversion, introduce gain
oczoske Aug 22, 2024
5e7f010
rename effect, add gain
oczoske Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions METIS/METIS_DET_IFU.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ properties:
ndit: "!OBS.ndit"
mindit: 1.3 # seconds, Roy van Boekel, pers. communication
full_well: !!float 1.E5 # electrons, E-TNT-MPIA-1004, v1-0
gain: 1. # electron/ADU TODO replace with realistic value
dark_current: 0.1 # [e-/s]
readout_noise: 70 # electrons, AI on RvB: check
layout:
Expand Down Expand Up @@ -72,8 +73,9 @@ effects:
noise_std: "!DET.readout_noise"
n_channels: 32

- name: quantization
description: Turn photon count into integers
class: Quantization
- name: ad_conversion
description: Apply gain and convert electron count into integers
class: ADConversion
kwargs:
dtype: uint16
gain: "!DET.gain"
12 changes: 9 additions & 3 deletions METIS/METIS_DET_IMG_N_GeoSnap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ changes:
- 2022-01-25 (KL, OC) added DetectorModePropertiesSetter effect
- 2022-01-26 (OC) added DET.detector, linearity set explicitely
- 2022-02-21 (OC) rename effects
- 2024-08-22 (OC) rename quantization to ADConversion, add gain
from Bowens2024 for high-capacity and a guess
for low-capacity

properties:
detector: Teledyne GeoSnap
Expand Down Expand Up @@ -38,6 +41,7 @@ effects:
description: "Geosnap, high-capacity mode"
"!DET.mindit": 0.011 # seconds
"!DET.full_well": !!float 2.8e6 # electrons
"!DET.gain": 195 # electron/ADU
"!DET.readout_noise": 300 # electrons (DCS)
"!DET.dark_current": !!float 1e5 # electrons/second
"!DET.linearity.incident": [0, !!float 2.8e6, !!float 1e99]
Expand All @@ -46,6 +50,7 @@ effects:
description: "Geosnap, low-capacity mode"
"!DET.mindit": 0.011 # seconds
"!DET.full_well": !!float 1.8e5 # electrons
"!DET.gain": 10 # electron/ADU (guess!)
"!DET.readout_noise": 35 # electrons (DCS)
"!DET.dark_current": !!float 1e5 # electrons/second
"!DET.linearity.incident": [0, !!float 1.8e5, !!float 1e99]
Expand Down Expand Up @@ -103,8 +108,9 @@ effects:
nod_offsets: "!OBS.nod_offsets"
pixel_scale: "!INST.pixel_scale"

- name: quantization
description: Turn photon count into integers
class: Quantization
- name: ad_conversion
description: Apply gain and convert electron count into integers
class: ADConversion
kwargs:
dtype: uint16
gain: "!DET.gain"
Loading