-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional cell to notebooks to reduce spectral resolution #120
Conversation
Run that cell when running the tests
I'm not really happy about this but I guess it's acceptable as a band aid. Ideally, some more explanation should be included on what
I don't object to merging for testing whether they run, but the notebooks should be refined a bit more after that. |
|
Switching off psfs should be tried first in the linelist thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay for the galaxies and sky spectra. For the line list, try switching off PSFs first.
I hit the 'Reference in new issue' item in the three-dot menu on your comment and created #122 . We can discuss it there further. |
I'll merge this, and add the sed line also to ScopeSim_Data. Let's see whether everything is green tomorrow. |
We changed the spectral resolution of the MICADO simulations in #103 . This lead to more accurate results, but now the notebooks take a lot of time and a lot of RAM (30+ GB), to the point that some of them won't run on most peoples computers, and also not on the github test runner.
I prefer to have the simulations accurate by default, even if that means they are slow. But at the same time it must also be easy to run the notebooks, because they are the primary way we communicate with users what to expect from ScopeSim and how to use it.
This PR adds a commented out line to the notebooks with instructions to the user to uncomment that line if they cannot run the simulation. The github test runner will automatically uncomment the line before running the tests (so it must be exactly this line).
The benefit of this PR is twofold:
It is perhaps OK to require 64GB of RAM (or more?), for the 'real' simulations that people will run on their institute cluster or so, but preferably people should be able to run them locally. We should therefore also figure out where all this memory consumption comes from and address it, but that is not this PR. (I see this PR as a band-aid.)
Note that the tests actually succeed, but I had to trigger them manually, because the notebooks are not ran automatically for a pull request: https://github.com/AstarVienna/irdb/actions/runs/5615876689 . I plan to merge this today, so we can see whether the nightly test run (which do include the notebooks) succeeds.